Skip to content

controllers: remove unused parameter resourceType #164

controllers: remove unused parameter resourceType

controllers: remove unused parameter resourceType #164

Triggered via push November 15, 2023 19:32
Status Failure
Total duration 5m 56s
Artifacts 1
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

ci.yaml

on: push
Matrix: drenv tests
Matrix: ramenctl tests
Matrix: Check artifacts and operator deployment
Publish built image
0s
Publish built image
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 10 warnings
Linters: .golangci.yaml#L42
42:7 [indentation] wrong indentation: expected 8 but found 6
Linters
Process completed with exit code 1.
Golangci Lint: controllers/kubeobjects/velero/requests.go#L252
string `backup` has 4 occurrences, make it a constant (goconst)
Golangci Lint: controllers/s3utils.go#L212
string `endpoint %s caller %s` has 3 occurrences, make it a constant (goconst)
Golangci Lint: controllers/vrg_volrep.go#L1765
string `VolumeReplicationGroup (%s/%s), %w` has 4 occurrences, make it a constant (goconst)
Golangci Lint: controllers/vrg_volrep.go#L1641
string `Unknown reason: ` has 3 occurrences, make it a constant (goconst)
Golangci Lint: controllers/s3utils.go#L211
string `empty bucket name for ` has 3 occurrences, make it a constant (goconst)
Golangci Lint: controllers/drplacementcontrol_controller_test.go#L1980
string ` by drpolicy controller since no DRPCs reference it anymore` has 3 occurrences, make it a constant (goconst)
Golangci Lint: controllers/drplacementcontrol_controller_test.go#L1979
string `should delete the DRPC causing its referenced drpolicy to be deleted` has 3 occurrences, make it a constant (goconst)
Golangci Lint
issues found
Unit tests
Process completed with exit code 2.
Golangci Lint: controllers/kubeobjects/requests.go#L110
unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/util/predicates.go#L13
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/util/predicates.go#L17
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/util/predicates.go#L25
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/util/mcv_util.go#L365
unused-parameter: parameter 'resourceType' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/vrg_kubeobjects.go#L171
unused-parameter: parameter 'result' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/vrg_kubeobjects.go#L172
unused-parameter: parameter 'captureStartTimeSince' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/vrg_kubeobjects.go#L190
unused-parameter: parameter 'captureStartGeneration' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/drcluster_controller.go#L413
unused-parameter: parameter 'log' seems to be unused, consider removing or renaming it as _ (revive)
Golangci Lint: controllers/drcluster_controller_test.go#L35
unused-parameter: parameter 'resourceName' seems to be unused, consider removing or renaming it as _ (revive)

Artifacts

Produced during runtime
Name Size
ramen-operator Expired
290 MB