golangci-lint: fix errorlint issues #161
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
ci.yaml
on: push
Matrix: Check artifacts and operator deployment
Publish built image
0s
Annotations
19 errors and 10 warnings
Linters:
.golangci.yaml#L42
42:7 [indentation] wrong indentation: expected 8 but found 6
|
Linters
Process completed with exit code 1.
|
Golangci Lint:
controllers/kubeobjects/velero/requests.go#L252
string `backup` has 4 occurrences, make it a constant (goconst)
|
Golangci Lint:
controllers/vrg_volrep.go#L1768
string `VolumeReplicationGroup (%s/%s), %w` has 4 occurrences, make it a constant (goconst)
|
Golangci Lint:
controllers/s3utils.go#L213
string `endpoint %s caller %s` has 3 occurrences, make it a constant (goconst)
|
Golangci Lint:
controllers/vrg_volrep.go#L1644
string `Unknown reason: ` has 3 occurrences, make it a constant (goconst)
|
Golangci Lint:
controllers/s3utils.go#L212
string `empty bucket name for ` has 3 occurrences, make it a constant (goconst)
|
Golangci Lint:
controllers/drplacementcontrol_controller_test.go#L1979
string `should delete the DRPC causing its referenced drpolicy to be deleted` has 3 occurrences, make it a constant (goconst)
|
Golangci Lint:
controllers/drplacementcontrol_controller_test.go#L1980
string ` by drpolicy controller since no DRPCs reference it anymore` has 3 occurrences, make it a constant (goconst)
|
Golangci Lint:
controllers/vrg_kubeobjects.go#L328
naked return in func `kubeObjectsGroupCapture` with 58 lines of code (nakedret)
|
Golangci Lint:
controllers/vrg_volsync.go#L79
naked return in func `reconcileVolSyncAsPrimary` with 42 lines of code (nakedret)
|
Golangci Lint:
controllers/vrg_volsync.go#L92
naked return in func `reconcileVolSyncAsPrimary` with 42 lines of code (nakedret)
|
Unit tests
Process completed with exit code 2.
|
drenv tests (3.10)
Process completed with exit code 2.
|
drenv tests (3.11)
The job was canceled because "_3_10" failed.
|
drenv tests (3.11)
Process completed with exit code 2.
|
drenv tests (3.9)
The job was canceled because "_3_10" failed.
|
drenv tests (3.9)
The operation was canceled.
|
Build image
Process completed with exit code 2.
|
Golangci Lint:
controllers/kubeobjects/requests.go#L110
unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/util/mcv_util.go#L347
unused-parameter: parameter 'resourceType' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/util/mcv_util.go#L356
unused-parameter: parameter 'resourceType' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/util/mcv_util.go#L365
unused-parameter: parameter 'resourceType' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/util/predicates.go#L13
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/util/predicates.go#L17
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/util/predicates.go#L25
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/s3utils.go#L117
unused-parameter: parameter 'log' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/vrg_kubeobjects.go#L171
unused-parameter: parameter 'result' seems to be unused, consider removing or renaming it as _ (revive)
|
Golangci Lint:
controllers/vrg_kubeobjects.go#L172
unused-parameter: parameter 'captureStartTimeSince' seems to be unused, consider removing or renaming it as _ (revive)
|