Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attachments to a new app #1813

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Sep 10, 2024

This PR moves attachments to misago.attachments app from misago.threads app.

Fixes #1805 and #1812

TODO

  • Create misago.attachments app
  • Move attachments data from misago.threads
  • Make attachment types hardcoded in misago.attachments
  • Write tests for the Attachment model
  • Move attachments admin to misago.admin
  • Validate that image type attachment is supported by Pillow
  • Store uploaded file as attachment
  • Store image dimensions on model
  • Plugin hook for initial attachment plugin_data
  • Let admins configure thumbnail dimensions
  • Add setting to disable attachments uploads globally
  • Add setting to disable attachments uploads in private threads
  • Add permission for uploading attachments in private threads
  • Pass attachments permissions to the PostForm
  • Pass attachments permissions to the PostForm in private threads
  • Update start thread posting state
  • Update post reply posting state
  • Update edit posting state
  • Resize textareas to accomondate new attachment UI
  • Use is_deleted flag on attachments for attachment deletion
  • Delete user's attachments
  • Delete thread's attachments
  • Delete category's attachments
  • Upload attachments with PostForm (without JavaScript)
  • Upload attachments with PostForm (with JavaScript)
  • Upload attachments with PostForm (JavaScript + paste file)
  • Upload attachments with PostForm (JavaScript + drag and drop)
  • Delete attachments from new post (without JavaScript)
  • Delete attachments from new post (with JavaScript)
  • Delete attachments from edited post (without JavaScript)
  • Delete attachments from edited post (with JavaScript)
  • Insert attachments in editor's textarea
  • Embed attachments in post body
  • Gateway attachment files behind permission check
  • Option to use NGINX X-Accel-Redirect to secure downloads
  • Use lightbox for viewing attachments
  • Open attachments on a dedicated page

Posting forms

  • Start thread
  • Start private thread
  • Reply thread
  • Reply private thread
  • Quick reply thread
  • Quick reply private thread
  • Edit thread
  • Edit private thread
  • Edit thread post
  • Edit private thread post
  • Inline edit thread
  • Inline edit private thread
  • Inline edit thread post
  • Inline edit private thread post

@rafalp rafalp added the area: backend This issue involves Python, Django or dependency (eg. database) label Sep 10, 2024
@rafalp rafalp added this to the Next feature release milestone Sep 10, 2024
@rafalp rafalp self-assigned this Sep 10, 2024
@rafalp rafalp added the feature: admin Affects admin control panel label Sep 10, 2024
@rafalp rafalp force-pushed the fix-1805-move-attachemts-to-app branch from 0cc2750 to 96fb0a4 Compare September 15, 2024 09:25
@rafalp rafalp added the feature: posting Start/reply/edit flows label Oct 29, 2024
@rafalp rafalp force-pushed the fix-1805-move-attachemts-to-app branch from 96fb0a4 to ef1b351 Compare January 5, 2025 12:20
@coveralls
Copy link

coveralls commented Jan 8, 2025

Coverage Status

coverage: 97.114% (+0.1%) from 97.013%
when pulling bffe225 on fix-1805-move-attachemts-to-app
into 2d4adc0 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) feature: admin Affects admin control panel feature: posting Start/reply/edit flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move attachments from misago.threads to misago.attachments.
2 participants