Add empty string support, culture based cast #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 17, 2024 01:25
…rors when decimal format is invalid, ie. double comma
enchev
reviewed
Jan 17, 2025
| @@ -489,14 +490,91 @@ public void Numeric_Supports_TypeConverter() | |||
|
|
|||
| var component = ctx.RenderComponent<RadzenNumeric<Dollars>>( | |||
| ComponentParameter.CreateParameter(nameof(RadzenNumeric<Dollars>.Format), format), | |||
| ComponentParameter.CreateParameter(nameof(RadzenNumeric<Dollars>.Value), valueToTest) | |||
| ComponentParameter.CreateParameter(nameof(RadzenNumeric<Dollars>.Value), valueToTest), | |||
| ComponentParameter.CreateParameter(nameof(RadzenNumeric<Dollars>.Culture), System.Globalization.CultureInfo.InvariantCulture) | |||
| ); | |||
There was a problem hiding this comment.
Why you need to specify Culture parameter here? This property is not mandatory, please make sure that everything works as expected without specified Culture.
There was a problem hiding this comment.
I add a test without culture, in my machine the culture is es-CL and the test fail if I don't specify culture, to ensure the string conversion I use
Assert.Contains($" value=\"{valueToTest.ToString(format, System.Globalization.CultureInfo.CurrentCulture)}\"", component.Markup);
to validate the render result, also add a new test using a specific culture to test both cases with and without culture set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add empty string support and culture base type conversion, update test suite to use culture and validate string to number conversion and empty string to zero value conversion.
Use component culture parameter to cast value to decimal type.