Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves initial setup and commit for adding typescript support to radon.js #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2018

##Initial Commit to Add Typescript Support:

  • Adds typescript to project as dev dependency
  • Adds types/ dir
  • Defines a few interfaces for library entities

This is not done yet

Will provide tests and finish out the definitions in next push.

Copy link
Collaborator

@hlmitchell hlmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, thanks for your contributions.

@ghost
Copy link
Author

ghost commented Oct 13, 2018

Thanks! Will spend some time writing some tests tonight!

@G0ldenSp00n-zz
Copy link
Collaborator

@MiguelSolano Were you going to push your test up, so that they could be merged with this PR.

@ghost
Copy link
Author

ghost commented Oct 23, 2018

Absolutely, just has taken me a minute to get time to wrap them up. They are still not done yet, but I do intend to get them done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants