Feature/382 refactor theme panel component #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main changes:
open
andonOpenChange
props to theThemePanel
component using theuseControllableState
hookThemePanel
andThemePanelImpl
components. Remove redundant interfacesuseHotKey
hook (no external dependencies)openHotkey
andtoogleAppearanceHotkey
propsnull
orfalse
to disable a hotkeyopenHotkey
is nullThings to improve in the future:
Control + F
orShift + H
useHotKey
implementation is very barebones. Consider using a library like react-hotkeys-hookTesting steps
Use cases:
Relates issues / PRs
Refs #382