[Tooltip] Prevent state change on unmounted component #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanselabreu
requested review from
benoitgrelard,
andy-hook,
vladmoroz and
lucasmotta
as code owners
|
Good catch. I'm facing the warnings you mentioned, and I probably think this is the reason. |
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue where the Tooltip attempts to set state on an unmounted component, leading to potential memory leaks and unexpected behavior.
Issue:
Currently the Tooltip attempts to update its state even after it has been unmounted. This results in warnings in the console and can lead to unpredictable behavior, particularly in asynchronous operations.
Proposed Solution:
To fix this issue, I have implemented a check to ensure that state is only updated if the component is still mounted. This is achieved by utilizing a boolean flag (
isMountedRef) to track the mounted state of the component. When the component is unmounted, this flag is set tofalse, preventing any state updates.