feature: use onBlur instead of native change event on FormControl change (Form package) #2715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think using React's onBlur event is a better choice here for a few reasons:
resetControlValidity();
call on line 402. So far so good, but the user types again and unfortunately makes the same mistake as before and ends up with the same incorrect value in the input. If he now clicks outside and the input loses focus, the native onChange event is not fired at all because the value is the same as before. So the user is left with an incorrectly filled input without even realising it.