straight--build-autoloads: Ensure output symlink isn't resolved (#701) #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an-software#701) In Emacs 28.1, when find-file-visit-truename, a user option, is non-nil, make-directory-autoloads resolves symlinks in its second argument (as it uses find-file-noselect under the hood) but not in its first. This results in relative paths that are invalid when loaded. See radian-software#701, radian-software#944, and upstream bug report https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52292.
kisaragi-hiu
force-pushed
the
workaround-truename
branch
from
7ec5f58 to
2458092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Emacs 28.1, when find-file-visit-truename, a user option, is non-nil, make-directory-autoloads resolves symlinks in its second argument (as it uses find-file-noselect under the hood) but not in its first. This results in relative paths that are invalid when loaded.
Although this should be fixed in upstream, as Emacs 28.1 is already released and a theoretical upstream fix would only come after an undetermined amount of time, a workaround like this should still be valuable.