Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

straight--build-compile: fix compile process load-path #1132

Merged
merged 1 commit into from
Oct 5, 2024
Merged

straight--build-compile: fix compile process load-path #1132

merged 1 commit into from
Oct 5, 2024

Conversation

progfolio
Copy link
Contributor

@progfolio progfolio commented Nov 18, 2023 •
edited
Loading

Compute child byte-compilation process load-path via straight-dependencies.
This should include the necessary transitive dependencies as well as
direct dependencies.

See: #1131

@progfolio progfolio mentioned this pull request Nov 18, 2023
Open
@progfolio
straight--build-compile: fix compile process load-path
3468d18 
Compute child byte-compilation process load-path via straight-dependencies.
This should include the necessary transitive dependencies as well as
direct dependencies.
@progfolio progfolio requested a review from raxod502 November 18, 2023 05:49
raxod502
raxod502 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@Patryk27
Copy link

Hi, I can also confirm this works!

I've got a problem where eat wasn't getting byte-compiled at all within Doom Emacs, because the current approach causes the byte-compiler to fail and stop on:

Checking /home/pwy/.emacs.d/.local/straight/build-29.4/eat/...
Compiling /home/pwy/.emacs.d/.local/straight/build-29.4/eat/eat-autoloads.el...
Compiling /home/pwy/.emacs.d/.local/straight/build-29.4/eat/eat.el...

In toplevel form:
eat.el:91:2: Error: Module is not GPL compatible: "/home/pwy/.emacs.d/.local/straight/build-29.4/tree-sitter-langs/bin/json.so"

Using the patch here helps and everything seems to be working correctly now 🙂

@hlissner hlissner mentioned this pull request Jul 26, 2024
Closed
4 tasks
hlissner added a commit to doomemacs/doomemacs that referenced this pull request Jul 26, 2024
@hlissner
fix(cli): some package files not being byte-compiled
54a084f 
Fix: #7707
Ref: radian-software/straight.el#1132
FrauH0lle added a commit to FrauH0lle/emacs.d that referenced this pull request Jul 31, 2024
@FrauH0lle
fix: Make straight compile invisible dependencies
38b9e53 
-  See radian-software/straight.el#1132
@raxod502 raxod502 merged commit 33fb469 into radian-software:develop Oct 5, 2024
4 checks passed
@progfolio progfolio deleted the fix/compile branch October 7, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@progfolio @Patryk27 @raxod502