Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test against ActiveSupport::RedisCacheStore v5 #632

Merged
merged 1 commit into from
Oct 24, 2023
Merged

ci: test against ActiveSupport::RedisCacheStore v5 #632

merged 1 commit into from
Oct 24, 2023

Conversation

santib
Copy link
Collaborator

@santib santib commented Oct 24, 2023 •
edited
Loading

Add gemfile to prevent regressions in ActiveSupport 5 which is actively supported by rack-attack

Note:

  • Changes in other gemfiles were done by Appraisals

@santib santib mentioned this pull request Oct 24, 2023
Merged
@santib santib force-pushed the add-gemfile-for-activesupport-5 branch from d39f511 to cb113f2 Compare October 24, 2023 16:17
@grzuy grzuy changed the title Add Gemfile for ActiveSupport 5 ci: test against ActiveSupport::RedisCacheStore v5 Oct 24, 2023
@grzuy grzuy enabled auto-merge (squash) October 24, 2023 22:12
@grzuy grzuy disabled auto-merge October 24, 2023 22:12
@grzuy grzuy enabled auto-merge (squash) October 24, 2023 22:13
grzuy
grzuy approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@grzuy grzuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Just realized the active_support_redis_cache_store appraisal points to activesupport v6. We're not testing against v7.

We may benefit from having one for each of those two, too.

@grzuy grzuy merged commit 070e467 into rack:main Oct 24, 2023
90 checks passed
@grzuy grzuy mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzuy grzuy grzuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santib @grzuy