Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add colored output" #1191

Closed
wants to merge 1 commit into from
Closed

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Apr 3, 2024

Reverts #1187

Copy link
Contributor

github-actions bot commented Apr 3, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 208d9c7 is merged into main:

  • ✔️cache_applying: 147ms -> 146ms [-2.76%, +1.37%]
  • ✔️cache_recording: 514ms -> 511ms [-1.21%, +0.25%]
  • ✔️without_cache: 982ms -> 985ms [-0.06%, +0.66%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator

Thanks. Let’s wait with merge because I am not yet fully convinced we should. More later…

@lorenzwalthert
Copy link
Collaborator

@olivroy to follow up, see my last comment #1189 (comment). Hence, I'd still consider your contribution valuable. Alternatively, we can think more fundamentally about how the R CLI for {styler} could improve. If you see yourself making contributions there, let's first discuss in an issue and then you can implement them if you want. But no pressure, either merging this or #1189 would also be fine for me.

@olivroy
Copy link
Contributor Author

olivroy commented Apr 11, 2024

Ok, yeah I see, maybe #1189 would be fine. Sacrifice a single mis-alignment for the greater good may be a good idea?

@olivroy olivroy closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants