Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when using non-absolute install_path #548

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix bug when using non-absolute install_path #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a547548
normalize install_path
gergness Oct 26, 2023
9df7095
update NEWS
gergness Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# covr (development version)
* Fix a bug preventing `package_coverage()` from running tests when `install_path` is set to a relative path (@gergness, #517, #548).

# covr 3.6.3

Expand Down
2 changes: 2 additions & 0 deletions R/covr.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,8 @@ package_coverage <- function(path = ".",
}

dir.create(install_path)
# tools::testInstalledPackage requires normalized install_path (#517)
install_path <- normalize_path(install_path)

flags <- getOption("covr.flags")

Expand Down