Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Add yarn support. Fix #958 #963

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add yarn support. Fix #958 #963

wants to merge 2 commits into from

Conversation

0xMRTT
Copy link

@0xMRTT 0xMRTT commented Jun 24, 2022

Standards checklist:

  • The PR title is descriptive.
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Fix issue #958 from @nicks-passiert

@nicks-passiert
Copy link

Thank you @0xMRTT, can't wait to use it!

@r-darwish
Copy link
Owner

Is this reasonable to run both npm and yarn? Do they have different sets of installed packages?

@nicks-passiert
Copy link

For me it is enough if I can choose if I use npm or yarn. For me there are no use cases where I would run both at the same time.

@0xMRTT
Copy link
Author

0xMRTT commented Jul 26, 2022

Okay, so we can add a new parameter to npm which is the path to the command for updating. By default it will be npm but you can change for yarn.

What do you think ?

@MCOfficer
Copy link
Contributor

The alternative is to do what topgrade already does for things like nala/apt: If tool X is a drop-in replacement designed to replace tool Y, and tool X is installed, run X instead of Y. In this case, yarn instead of npm.

@0xMRTT
Copy link
Author

0xMRTT commented Jul 26, 2022

The alternative is to do what topgrade already does for things like nala/apt: If tool X is a drop-in replacement designed to replace tool Y, and tool X is installed, run X instead of Y. In this case, yarn instead of npm.

But if you have yarn and npm, maybe you need to choose

@nicks-passiert
Copy link

Both would be for me good. Maybe it would be good to choose, to have a solution for the most users.

@nicks-passiert
Copy link

I tested it on MacOS and it works for me

@nicks-passiert
Copy link

What is to do, to get this done here?

@MCOfficer
Copy link
Contributor

What is to do, to get this done here?

afaict roey is just gone for a bit. Gotta wait for them to come back.

@s34m
Copy link

s34m commented Oct 11, 2022

Merged at new fork because of inactivity by maintainer.

@0xMRTT
Copy link
Author

0xMRTT commented Oct 11, 2022

Oh, what about creating an org for that ?

@s34m
Copy link

s34m commented Oct 11, 2022

Oh, what about creating an org for that ?

Will be done in the future, currently in the progress of just looking at current issues and PRs

@0xMRTT
Copy link
Author

0xMRTT commented Oct 11, 2022

I'll be glad to help you

@s34m
Copy link

s34m commented Oct 11, 2022

Oh, what about creating an org for that ?

Here it is: https://github.com/topgrade-rs/topgrade

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants