This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 159
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable updating Toolbx through topgrade (#830)
* steps: toolbox: Add module to upgrade toolboxes This adds a module to upgrade all toolboxes found on a host system. [Toolbox][1] (More recently: `toolbx`) is a tool that easily provides mutable, containerized command line environments. It is a means to work and develop in a mutable environment on immutable operating systems such as Fedora Silverblue, CoreOS, Kinoite and much more. However, it is not limited to these use cases. The integration into topgrade works as follows: Toolbx makes many of the hosts folders available form inside the toolbx container by default. In particular, all of the hosts filesystem is mapped under `/run/host`. This module exploits this fact by: - Gathering a list of toolboxes available on the host that runs `topgrade` - Executing `toolbox run` for each of these toolboxes to run a command inside the toolboxes, **using the executing `topgrade` executable with the `--only system` arguments** [1]: https://containertoolbx.org/ * toolbx: Integrate toolbx into the application * Toolbx is Linux specific Co-authored-by: Roey Darwish Dror <[email protected]>
- Loading branch information
1 parent
4932be1
commit da8cf9d
Showing
4 changed files
with
65 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,6 +126,7 @@ pub enum Step { | |
Tldr, | ||
Tlmgr, | ||
Tmux, | ||
Toolbx, | ||
Vagrant, | ||
Vcpkg, | ||
Vim, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
use anyhow::Result; | ||
|
||
use crate::config::Step; | ||
use crate::terminal::print_separator; | ||
use crate::{execution_context::ExecutionContext, utils::require}; | ||
use log::debug; | ||
use std::path::Path; | ||
use std::{path::PathBuf, process::Command}; | ||
|
||
fn list_toolboxes(toolbx: &Path) -> Result<Vec<String>> { | ||
let output = Command::new(toolbx).args(&["list", "--containers"]).output()?; | ||
let output_str = String::from_utf8(output.stdout)?; | ||
|
||
let proc: Vec<String> = output_str | ||
.lines() | ||
// Skip the first line since that contains only status information | ||
.skip(1) | ||
.map(|line| match line.split_whitespace().nth(1) { | ||
Some(word) => word.to_string(), | ||
None => String::from(""), | ||
}) | ||
.filter(|x| !x.is_empty()) | ||
.collect(); | ||
|
||
Ok(proc) | ||
} | ||
|
||
pub fn run_toolbx(ctx: &ExecutionContext) -> Result<()> { | ||
let toolbx = require("toolbox")?; | ||
|
||
print_separator("Toolbx"); | ||
let toolboxes = list_toolboxes(&toolbx)?; | ||
debug!("Toolboxes to inspect: {:?}", toolboxes); | ||
|
||
let mut topgrade_path = PathBuf::from("/run/host"); | ||
// Path of the running topgrade executable | ||
// Skip 1 to eliminate the path root, otherwise push overwrites the path | ||
topgrade_path.push(std::env::current_exe()?.components().skip(1).collect::<PathBuf>()); | ||
let topgrade_path = topgrade_path.to_str().unwrap(); | ||
|
||
for tb in toolboxes.iter() { | ||
let topgrade_prefix = format!("TOPGRADE_PREFIX='Toolbx {}'", tb); | ||
let mut args = vec![ | ||
"run", | ||
"-c", | ||
tb, | ||
"env", | ||
&topgrade_prefix, | ||
topgrade_path, | ||
"--only", | ||
"system", | ||
]; | ||
if ctx.config().yes(Step::Toolbx) { | ||
args.push("--yes"); | ||
} | ||
|
||
let _output = ctx.run_type().execute(&toolbx).args(&args).check_run(); | ||
} | ||
|
||
Ok(()) | ||
} |