Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #51

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

EdgarScott
Copy link

Hi. I've analysed your codebase and noticed that it is not fully tested.
I've written some tests for the methods in the following classes with the help of Diffblue Cover:

  • qunar.tc.bistoury.clientside.common.meta.Numbers
  • qunar.tc.decompiler.code.Instruction
  • qunar.tc.decompiler.code.SwitchInstruction
  • qunar.tc.decompiler.main.extern.IIdentifierRenamer_Type
  • qunar.tc.decompiler.modules.renamer.ConverterHelper
  • qunar.tc.decompiler.struct.attr.StructAnnDefaultAttribute
  • qunar.tc.decompiler.struct.attr.StructAnnotationAttribute
  • qunar.tc.decompiler.struct.attr.StructAnnotationParameterAttribute
  • qunar.tc.decompiler.struct.attr.StructBootstrapMethodsAttribute
  • qunar.tc.decompiler.struct.attr.StructConstantValueAttribute
  • qunar.tc.decompiler.struct.attr.StructEnclosingMethodAttribute
  • qunar.tc.decompiler.struct.attr.StructExceptionsAttribute
  • qunar.tc.decompiler.struct.attr.StructGeneralAttribute
  • qunar.tc.decompiler.struct.attr.StructGenericSignatureAttribute
  • qunar.tc.decompiler.struct.attr.StructInnerClassesAttribute
  • qunar.tc.decompiler.struct.attr.StructLineNumberTableAttribute
  • qunar.tc.decompiler.struct.attr.StructMethodParametersAttribute
  • qunar.tc.decompiler.struct.gen.VarType
  • qunar.tc.decompiler.struct.gen.generics.GenericType
  • qunar.tc.decompiler.util.InterpreterUtil
  • qunar.tc.bistoury.instrument.client.spring.el.CodeFlow
  • qunar.tc.bistoury.instrument.client.spring.el.CollectionUtils
  • qunar.tc.bistoury.instrument.client.spring.el.NestedExceptionUtils
  • qunar.tc.bistoury.instrument.client.spring.el.ObjectUtils
  • qunar.tc.bistoury.instrument.client.spring.el.Operator_DescriptorComparison
  • qunar.tc.bistoury.instrument.client.spring.el.StringUtils
  • qunar.tc.bistoury.serverside.agile.Base64
  • qunar.tc.bistoury.serverside.agile.Strings

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.

These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
…_Type

These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
…tribute

These tests were written using Diffblue Cover
…tribute

These tests were written using Diffblue Cover
…rameterAttribute

These tests were written using Diffblue Cover
…hodsAttribute

These tests were written using Diffblue Cover
…eAttribute

These tests were written using Diffblue Cover
…hodAttribute

These tests were written using Diffblue Cover
…tribute

These tests were written using Diffblue Cover
…bute

These tests were written using Diffblue Cover
…tureAttribute

These tests were written using Diffblue Cover
…Attribute

These tests were written using Diffblue Cover
…bleAttribute

These tests were written using Diffblue Cover
…tersAttribute

These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
…Flow

These tests were written using Diffblue Cover
…ectionUtils

These tests were written using Diffblue Cover
…edExceptionUtils

These tests were written using Diffblue Cover
…ctUtils

These tests were written using Diffblue Cover
…ator_DescriptorComparison

These tests were written using Diffblue Cover
…ngUtils

These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
These tests were written using Diffblue Cover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants