Skip to content

Commit

Permalink
[DAEC-14] Fix Slack error not correctly being returned (#11)
Browse files Browse the repository at this point in the history
  • Loading branch information
athossampayo authored Dec 1, 2022
1 parent 7a2b584 commit ca4fdfb
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.

Preferably use **Added**, **Changed**, **Removed** and **Fixed** topics in each release or unreleased log for a better organization.

## [1.0.1](https://github.com/quintoandar/validations-engine/releases/tag/1.0.1)
### Fixed
SlackHelper send_slack_errors method returns the correct Boolean value depending on the success of messages.
## [1.0.0](https://github.com/quintoandar/validations-engine/releases/tag/1.0.0)
### Added
First modules and entities of Validations Engine package.
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.1.0
current_version = 1.0.1
commit = True
tag = True

Expand Down
9 changes: 2 additions & 7 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from setuptools import setup, find_packages

__package_name__ = "validations_engine"
__version__ = "1.0.0"
__version__ = "1.0.1"
__repository_url__ = "https://github.com/quintoandar/validations-engine"


Expand All @@ -22,12 +22,7 @@
keywords=["python", "validations", "validations-engine"],
version=__version__,
url=__repository_url__,
packages=find_packages(
include=[
"validations_engine",
"validations_engine.*",
]
),
packages=find_packages(include=["validations_engine", "validations_engine.*"]),
author="QuintoAndar",
install_requires=requirements,
python_requires=">=3.7, <4",
Expand Down
2 changes: 1 addition & 1 deletion validations_engine/SlackHelper.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def send_slack_errors(error_messages: List[Tuple[str, str]]) -> bool:
f" the webhook url: channel:{channel}, payload:{payload},"
f" error: {e}"
)
response_success |= False
response_success = False
return response_success

@staticmethod
Expand Down

0 comments on commit ca4fdfb

Please sign in to comment.