Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing trait imports on non-unix read_bytes implementation #2154

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

ChillFish8
Copy link
Collaborator

Closes #2153

Adds the missing traits for non-unix systems in the file_slice file with the WrapFile::read_bytes method.

@codecov-commenter
Copy link

Codecov Report

Merging #2154 (fd3de7c) into main (e6cacc4) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   94.25%   94.26%   +0.01%     
==========================================
  Files         320      320              
  Lines       62112    62112              
==========================================
+ Hits        58541    58550       +9     
+ Misses       3571     3562       -9     
Files Changed Coverage Δ
common/src/file_slice.rs 65.51% <ø> (ø)

... and 2 files with indirect coverage changes

@fulmicoton fulmicoton merged commit 131c10d into quickwit-oss:main Aug 27, 2023
@fulmicoton
Copy link
Collaborator

thank you!

ethever pushed a commit to ethever/tantivy that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main branch is broken on non-unix systems
3 participants