[do-not-merge] report capacity in metrics #4569
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Feb 13, 2024
| @@ -212,7 +212,7 @@ impl Queues { | |||
| self.record_log.disk_usage() | |||
| } | |||
|
|
|||
| pub(crate) fn memory_usage(&self) -> usize { | |||
There was a problem hiding this comment.
We need to fix the mrecordlog API. There is no way anyone can understand what this couple is about.
There was a problem hiding this comment.
as is, it is meant for debugging. having 3 function doing similar things seems to much. If this is to get merged, I plan on having a single one returning a struct
|
@trinity-1686a, I'm interested in this patch. Could you fix the mrecordlog API to return a single struct and update this PR when you can? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.