fix: change holoiso regexp to match shorter release tags #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lj3954
requested changes
Jun 25, 2024
| @@ -828,7 +828,7 @@ function editions_haiku() { | |||
| } | |||
|
|
|||
| function releases_holoiso() { | |||
| web_pipe "https://github.com/HoloISO/releases/releases/latest" | grep -o -e 'releases/tag/[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]' | head -n 1 | cut -d'/' -f 3 | |||
| web_pipe "https://github.com/HoloISO/releases/releases/latest" | grep -o -e 'releases/tag/[[:digit:]]\+\(\.[[:digit:]]\+\)*' | head -n 1 | cut -d'/' -f 3 | |||
There was a problem hiding this comment.
Most other releases_ and get_ functions rely on the GitHub API, which is almost certainly a better idea for performance & stability reasons.
Additionally, the preferred style for quickget releases & editions functions appears to always involve use of echo, whether or not it's necessary.
Suggested change
| web_pipe "https://github.com/HoloISO/releases/releases/latest" | grep -o -e 'releases/tag/[[:digit:]]\+\(\.[[:digit:]]\+\)*' | head -n 1 | cut -d'/' -f 3 | |
| #shellcheck disable=SC2046,SC2005 | |
| echo $(web_pipe "https://api.github.com/repos/HoloISO/releases/releases" | grep "tag_name" | cut -d'"' -f 4 | head -n +2) |
There was a problem hiding this comment.
Releases should also never be truncated to the length 1, since in that case there's no point checking for releases, just offer the user a "latest" option and determine the latest release within the get_ function.
flexiondotorg
added a commit
that referenced
this pull request
Jun 25, 2024
flexiondotorg
added a commit
that referenced
this pull request
Jun 25, 2024
flexiondotorg
added a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1301