-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data races #4239
base: master
Are you sure you want to change the base?
Fix data races #4239
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4239 +/- ##
==========================================
+ Coverage 84.13% 84.15% +0.02%
==========================================
Files 150 149 -1
Lines 15404 15395 -9
==========================================
- Hits 12960 12955 -5
+ Misses 1945 1942 -3
+ Partials 499 498 -1 ☔ View full report in Codecov by Sentry. |
Is this why the test on CI is flaky? We're not running test in parallel, do we? |
Yes, I think so. |
Still not sure if tests run in parallel with However, I can reproduce the data race on my machine on Command: Output:
|
Update: |
this commit 899031a fixes only the problem with |
That data race is caused by The problem can be solved by explicitly calling destroy or close on the server connection instances. |
this is still wip |
dec7c06
to
7003515
Compare
Thank you for working on this @birneee, these races have been annoying me for a long time. Really appreciate your debugging efforts here! |
I cannot reproduce the error that happened in |
7003515
to
f368a53
Compare
@birneee What's the status of this PR? |
@marten-seemann it is still in progress. |
Test that modify global variables should not run simultaneously with other tests.