Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listShards to only specify nextToken #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anthuang
Copy link

This fixes two bugs:

  1. If listShards returns multiple pages, then we run into an infinite loop with while (!nextToken.isEmpty), because nextToken will never be set back to null because:
if (returnedToken != null) {
  nextToken = returnedToken
  1. listShards cannot allow both StreamName and NextToken to be specified together.

@chadlagore
Copy link
Contributor

@itsvikramagr this is tested against streams with >1k shards which forces paging on the Kinesis API

@itsmesrds
Copy link

Does this read the equal number of messages too ? because I see there is a data skew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants