fix: allow use publicPath #125
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the public path of your app specified in property `publicPath` in quasar.conf.js
|
Thank you I will inform @hawkeye64 and when everything is ok i merge it |
|
Any update on this? |
Have you had a chance to test this? |
|
I'm afraid this solution might lead to issues when using vue router in history mode, as the relative path would include vue pages instead of the public directory. I've tried to solve this in #132 by passing the publicPath config value through the boot file to the component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the public path of your app specified in property
publicPathin quasar.conf.jsCloses #123