Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and style review for the TLS reference guide #45821

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

MichalMaler
Copy link
Contributor

Providing a brief review after some new content was added to this guide.

@MichalMaler MichalMaler requested a review from jmartisk January 23, 2025 11:41
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 23, 2025
@MichalMaler MichalMaler force-pushed the tls-registry-patch-review branch from de36ebf to 803abce Compare January 23, 2025 11:44
Copy link

github-actions bot commented Jan 23, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@MichalMaler MichalMaler force-pushed the tls-registry-patch-review branch from 803abce to f48b734 Compare January 23, 2025 13:34
@MichalMaler
Copy link
Contributor Author

Thank you, @cescoffier and @jmartisk, for your review and for moving this forward! Epic co-work, as always. Cheers!

This comment has been minimized.

@MichalMaler MichalMaler added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 23, 2025
Signed-off-by: Michal Maléř <[email protected]>
@MichalMaler MichalMaler force-pushed the tls-registry-patch-review branch from f48b734 to 99197ff Compare January 23, 2025 15:51
Copy link

quarkus-bot bot commented Jan 23, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 99197ff.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit 73edaee into quarkusio:main Jan 27, 2025
5 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 27, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants