Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert kafka-streams extension to use @ConfigMapping #45817

Closed
wants to merge 1 commit into from
Closed

Convert kafka-streams extension to use @ConfigMapping #45817

wants to merge 1 commit into from

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Jan 23, 2025 •
edited by gsmet
Loading

Convert kafka-streams to use @ConfigMapping

Part of #45446

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

🎊 PR Preview ea4fb8a has been successfully built and deployed to https://quarkus-pr-main-45817-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

gsmet
gsmet requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot io.quarkus.kafka.streams.runtime.SslConfig for this one :).

Probably a good idea to search for @ConfigGroup as these things are easy to miss!

@gsmet
Copy link
Member

gsmet commented Jan 23, 2025

I modified the description to change Fixes to Part of or otherwise merging the PR will close the issue.

@mcruzdev
Copy link
Contributor Author

Thank you @gsmet, I will squash soon.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Jan 24, 2025

There are still a bunch of them missing:

2025-01-23T22:17:45.1090817Z 	java.lang.IllegalArgumentException: SRCFG00013: No Converter registered for class io.quarkus.kafka.streams.runtime.TrustStoreConfig
2025-01-23T22:17:45.1092666Z 	java.lang.IllegalArgumentException: SRCFG00013: No Converter registered for class io.quarkus.kafka.streams.runtime.KeyStoreConfig
2025-01-23T22:17:45.1094097Z 	java.lang.IllegalArgumentException: SRCFG00013: No Converter registered for class io.quarkus.kafka.streams.runtime.KeyConfig

While I would not run the full test suite locally, I recommend to run the tests for the extension and the related IT (when there is one easily identifiable). It makes the feedback loop a lot shorted. You don't catch all issues but you catch most of them.

@mcruzdev
Copy link
Contributor Author

Sorry, I did it in a hurry yesterday before leaving work, I'll try to do it more calmly today

@mcruzdev mcruzdev force-pushed the config-kafka-streams branch from 59ce094 to 0e829f5 Compare January 24, 2025 11:58
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 24, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0e829f5.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs 🔍
✖ JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
✖ Native Tests - Messaging1 Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/kafka-streams

📦 integration-tests/kafka-streams

✖ io.quarkus.it.kafka.streams.KafkaStreamsCdiEventTest.testEventShouldBePublished - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

✖ io.quarkus.it.kafka.streams.KafkaStreamsPropertiesTest.testProperties - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

✖ io.quarkus.it.kafka.streams.KafkaStreamsStartupFailureTest.testShutdownBeforeKStreamsStarted - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

✖ io.quarkus.it.kafka.streams.KafkaStreamsTest.testKafkaStreams - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/kafka-streams

📦 integration-tests/kafka-streams

✖ io.quarkus.it.kafka.streams.KafkaStreamsCdiEventTest.testEventShouldBePublished - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

✖ io.quarkus.it.kafka.streams.KafkaStreamsPropertiesTest.testProperties - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

✖ io.quarkus.it.kafka.streams.KafkaStreamsStartupFailureTest.testShutdownBeforeKStreamsStarted - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

✖ io.quarkus.it.kafka.streams.KafkaStreamsTest.testKafkaStreams - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:695)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/kafka-streams

📦 integration-tests/kafka-streams

✖ io.quarkus.it.kafka.streams.KafkaStreamsITCase.testKafkaStreams - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Unable to successfully launch process '4584'. Exit code is: '1'.
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:336)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:114)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Unable to successfully launch process '4584'. Exit code is: '1'.
	at io.quarkus.test.common.LauncherUtil.ensureProcessIsAlive(LauncherUtil.java:120)
	at io.quarkus.test.common.LauncherUtil.waitForCapturedListeningData(LauncherUtil.java:83)

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 24, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 0e829f5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mcruzdev
Copy link
Contributor Author

Closing to evict to call the pipeline each push.

@mcruzdev mcruzdev closed this Jan 24, 2025
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jan 24, 2025
@mcruzdev
Copy link
Contributor Author

Replaced by #45853 (I made a force push 🤣 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet requested changes

Assignees
No one assigned
Labels
area/kafka-streams triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcruzdev @gsmet