-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert kafka-client extension to use @ConfigMapping #45816
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There's something fishy:
Let me have a closer look. |
Maybe you forgot to convert |
Thank you @gsmet, I will squash soon. |
🎊 PR Preview ea4fb8a has been successfully built and deployed to https://quarkus-pr-main-45816-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks good to go once squashed.
f189f33
to
37fb63f
Compare
Status for workflow
|
Status for workflow
|
Thanks! |
Convert kafka-client to use @ConfigMapping
Part of #45446