Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert kafka-client extension to use @ConfigMapping #45816

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Jan 23, 2025

Convert kafka-client to use @ConfigMapping

Part of #45446

This comment has been minimized.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jan 23, 2025

There's something fishy:

2025-01-23T11:12:31.1455219Z [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:generate-code (default) on project quarkus-integration-test-kafka-avro-apicurio2: Quarkus code generation phase has failed: InvocationTargetException: Failed to initialize application configuration: Configuration validation failed:
2025-01-23T11:12:31.1461049Z [ERROR] 	java.lang.IllegalArgumentException: SRCFG00013: No Converter registered for class io.quarkus.kafka.client.deployment.KafkaDevServicesBuildTimeConfig
2025-01-23T11:12:31.1462358Z [ERROR] -> [Help 1] .

Let me have a closer look.

@gsmet
Copy link
Member

gsmet commented Jan 23, 2025

Maybe you forgot to convert KafkaDevServicesBuildTimeConfig?

@mcruzdev
Copy link
Contributor Author

Thank you @gsmet, I will squash soon.

Copy link

github-actions bot commented Jan 23, 2025

🎊 PR Preview ea4fb8a has been successfully built and deployed to https://quarkus-pr-main-45816-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to go once squashed.

@mcruzdev mcruzdev force-pushed the config-kafka-client branch from f189f33 to 37fb63f Compare January 24, 2025 11:59
Copy link

quarkus-bot bot commented Jan 24, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 37fb63f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jan 24, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 37fb63f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit cb7b1a1 into quarkusio:main Jan 24, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 24, 2025
@gsmet
Copy link
Member

gsmet commented Jan 24, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants