-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extensions to contribute datasouces #45808
base: main
Are you sure you want to change the base?
Allow extensions to contribute datasouces #45808
Conversation
Making this build item public should allow extension to contribute extensions at build time. This allows the possiblity of defining datasources as code rather than config. Runtime attributes still need to be provided as config, however it is already possible for extensions to provide runtime config so this is not really a concern.
🎊 PR Preview 4198ee4 has been successfully built and deployed to https://quarkus-pr-main-45808-preview.surge.sh/version/main/guides/
|
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I'm opposed to allowing this, but... we're essentially taking internals, and declaring "that's public now", without any kind of documentation or tests.
If we do this, I can't guarantee we won't break it unexpectedly later. In fact I can pretty much guarantee we will break it unexpectedly later.
Making this build item public should allow extension to contribute extensions at build time. This allows the possiblity of defining datasources as code rather than config.
Runtime attributes still need to be provided as config, however it is already possible for extensions to provide runtime config so this is not really a concern.