swapi.dev is down, use swapi.tech #45335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
geoand
approved these changes
Jan 3, 2025
gsmet
reviewed
Jan 6, 2025
| @@ -135,7 +135,7 @@ them to the client as JSON using xref:rest-json.adoc[Jackson or JSON-B]: | |||
| // Create a REST client to the Star Wars API | |||
| WebClient client = WebClient.create(vertx, | |||
| new WebClientOptions() | |||
| .setDefaultHost("swapi.dev") | |||
| .setDefaultHost("swapi.net") | |||
There was a problem hiding this comment.
The title of the PR says tech and the quickstart change says tech but here we have a net? Is it expected?
There was a problem hiding this comment.
Good catch @gsmet, it should be .tech as commit message says, I will create fix PR soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swapi.dev is down, use swapi.tech
swapi-graphql change: graphql/swapi-graphql@b340cf9
Related QS change: quarkusio/quarkus-quickstarts#1484