-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micrometer to OpenTelemetry Bridge #43831
Conversation
/cc @ebullient (micrometer) |
🙈 The PR is closed and the preview is expired. |
7b7cc9f
to
acd0b25
Compare
acd0b25
to
35f4d7a
Compare
73b8d37
to
b7ae30d
Compare
d384469
to
7375f46
Compare
// // registered to this registry... | ||
// // It's unavoidable because of how Quarkus startup works and users cannot do anything about it. | ||
// // see: https://github.com/micrometer-metrics/micrometer/issues/4920#issuecomment-2298348202 | ||
// systemProperty.produce( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radcortez I wonder why this didn't work here... I had to set these properties in the runtime application.properties
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7375f46
to
cece5ed
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cece5ed
to
6647f75
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6647f75
to
17812ae
Compare
This comment has been minimized.
This comment has been minimized.
3bfddac
to
02659ec
Compare
This comment has been minimized.
This comment has been minimized.
02659ec
to
53c8374
Compare
This comment has been minimized.
This comment has been minimized.
Thanks @geoand :) |
🙏🏽 |
This comment has been minimized.
This comment has been minimized.
53c8374
to
47d5c7b
Compare
rebased |
This comment has been minimized.
This comment has been minimized.
There's something wrong with the branch... It's not piking up the conflicts on |
This comment has been minimized.
This comment has been minimized.
This is done because we need sometimes need to tweak the logging categories and the corresponding build items have no effect if logging has not yet been setup
All good after all. Holly's native-tests.json reorg is not on main and I got confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few minor suggestions, questions, mostly to the doc.
I would recommend fixing all the easy stuff before merging and then we can discuss the remaining points after merge if they require some discussion.
docs/src/main/asciidoc/telemetry-micrometer-to-opentelemetry.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/telemetry-micrometer-to-opentelemetry.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/telemetry-micrometer-to-opentelemetry.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/telemetry-micrometer-to-opentelemetry.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/telemetry-micrometer-to-opentelemetry.adoc
Outdated
Show resolved
Hide resolved
47d5c7b
to
a6c8a69
Compare
Addressed the review @gsmet |
Status for workflow
|
Status for workflow
|
I just saw this had the backport label, I don't think we can backport it, it's too much of a change, it's going to be for 3.19. |
That's fine. |
solves #43621
The implementation uses the opentelemetry-micrometer-1.5 library.
This allows us to create a Micrometer registry implemented with the OpenTelemetry SDK and APIs.
All telemetry data created with both Micrometer and OpenTelemetry will be processed by the same OpenTelemetry SDK instance from the
quarkus-opentelemetry
extension and will use it's configuration and exporters.quarkus-micrometer
extension configurations should also work, as verified on some tests.Missing:
io.ope.ins.mic.v1_.OpenTelemetryMeterRegistry] (main) A MeterFilter is being configured ...