Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated @QuarkusTestResource to @WithTestResource #1435

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Jul 25, 2024

Updating deprecated @QuarkusTestResource to @WithTestResource as it's new in 3.13.0 https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13#quarkustestresource-replaced-by-withtestresource-gear-white_check_mark

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

This comment has been minimized.

@jedla97 jedla97 force-pushed the remove-quarkusTestResource branch from 5265844 to 6b787e1 Compare July 25, 2024 13:25

This comment has been minimized.

Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

I added a question

@@ -0,0 +1,81 @@
version: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file added by accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was plaing with and forgot that I added it.

Now removed

@@ -0,0 +1,81 @@
version: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@jedla97 jedla97 force-pushed the remove-quarkusTestResource branch from 6b787e1 to 3021d81 Compare July 26, 2024 09:01
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

quarkus-bot bot commented Jul 26, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 3021d81.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit b5dacc1 into quarkusio:development Jul 26, 2024
2 checks passed
@jedla97 jedla97 deleted the remove-quarkusTestResource branch July 26, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants