Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency addition needed by Flyway 10 #1398

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

rsvoboda
Copy link
Member

Dependency addition needed by Flyway 10

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Mar 19, 2024

We will have to wait until 3.9 is released to merge this one. Unless we backport Flyway 10 to 3.9 but people don't look that excited about the idea.

@gsmet
Copy link
Member

gsmet commented Mar 27, 2024

Rebased as I wanted to get a full CI run for other purposes.

This comment has been minimized.

@rsvoboda
Copy link
Member Author

rsvoboda commented Apr 3, 2024

@gsmet can be this merged now?

https://github.com/quarkusio/quarkus-quickstarts/tree/3.9 was created

@rsvoboda
Copy link
Member Author

rsvoboda commented Apr 5, 2024

Rebasing to pick the latest changes

Copy link

quarkus-bot bot commented Apr 5, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 71e0370.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing: security-openid-connect-multi-tenancy-quickstart 

📦 security-openid-connect-multi-tenancy-quickstart

org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants line 89 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <Sign in to quarkus> but was: <>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants(CodeFlowTest.java:89)

@gsmet gsmet merged commit 137097f into quarkusio:development Apr 5, 2024
2 of 3 checks passed
@gsmet
Copy link
Member

gsmet commented Apr 5, 2024

@sberyozkin @michalvavrik this CodeFlowTest looks concerning to me ^

@michalvavrik
Copy link
Member

@sberyozkin @michalvavrik this CodeFlowTest looks concerning to me ^

Sergey did fixes (I won't look for the PR, it's the one with the cookie resolution), tenant a is selected instead of the default one because there is a cookie session io.quarkus.oidc.runtime.OidcAuthenticationMechanism#setTenantIdAttribute(io.vertx.ext.web.RoutingContext). Problem is that convention resolver should have a priority (path end withs /default). My best guess would be that TENANT_ID_ATTRIBUTE but it isn't the value of the default one because we don't set that null there @sberyozkin ? Anyway, I didn't debug it properly because Sergey has been into this in last week, he should have a look.

@rsvoboda rsvoboda deleted the flyway-10.10 branch December 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants