-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency addition needed by Flyway 10 #1398
Conversation
This comment has been minimized.
This comment has been minimized.
We will have to wait until 3.9 is released to merge this one. Unless we backport Flyway 10 to 3.9 but people don't look that excited about the idea. |
Rebased as I wanted to get a full CI run for other purposes. |
This comment has been minimized.
This comment has been minimized.
@gsmet can be this merged now? https://github.com/quarkusio/quarkus-quickstarts/tree/3.9 was created |
Rebasing to pick the latest changes |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs |
---|---|---|---|---|---|
✖ | Build - JDK 17 | Build with Maven |
Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
Failures
⚙️ Build - JDK 17 #
- Failing: security-openid-connect-multi-tenancy-quickstart
📦 security-openid-connect-multi-tenancy-quickstart
✖ org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants
line 89
- More details - Source on GitHub
org.opentest4j.AssertionFailedError: expected: <Sign in to quarkus> but was: <>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants(CodeFlowTest.java:89)
@sberyozkin @michalvavrik this |
Sergey did fixes (I won't look for the PR, it's the one with the cookie resolution), tenant a is selected instead of the default one because there is a cookie session |
Dependency addition needed by Flyway 10
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md