Add ability to sort extensions by downloads, using Tableau download stats #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
popularity-sort
branch
2 times, most recently
from
d58ef9b to
532f033
Compare
holly-cummins
force-pushed
the
popularity-sort
branch
from
532f033 to
ec246cc
Compare
|
🙈 The PR is closed and the preview is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I'd have to do this by hand with manual uploads of download data, but I found the Tableau rest api and got it working. So this should stay current as long as we continue to get refreshes of the workbook and view we're using. Because it needs a secret for the Tableau access token, this won't render in the PR preview, but this is what I see locally:
The message about the date only shows when sort by downloads is selected. I've verified the order against the table in the Tableau UI.
Partial resolution of #856. One problem is that we only have the artifact id, not the group id, in the raw data, so the json-logging downloads will get double-counted and can't be split (yet). I've raised #951.
cc @maxandersen and @gastaldi, because this is a notable data enrichment.