Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes mistype #105

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Fixes mistype #105

wants to merge 5 commits into from

Conversation

EgorWeders
Copy link

Fixes comment mistype

langlor-autodesk pushed a commit to autodesk-forks/qtbase that referenced this pull request Nov 11, 2024
@senthilauto2023
Revert "MAYA-132611: Crash when docking the Select a light source (qt…
886d1f5 
…#102)" (qt#105)

#28746 was made to use an older artifact for Maya 2025.2 to save precious hours that would have been otherwise spent on waiting for the Qt build to complete. This PR aims to solve it properly by reverting the offending change specifically. This also allows us to resolve MAYA-132068

This reverts commit aaca5d7.
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Nov 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pr-replication-bot
Copy link

The author of this PR is using a GitHub noreply email address.
Thank you for your contribution to The Qt Project. Unfortunately, the Qt Project can only accept contributions from users with a reachable email address. If you wish for this PR to be considered, please update your email address privacy settings in your GitHub account settings.

@pr-replication-bot
Copy link

The author of this PR is using a GitHub noreply email address.
Thank you for your contribution to The Qt Project. Unfortunately, the Qt Project can only accept contributions from users with a reachable email address. If you wish for this PR to be considered, please update your email address privacy settings in your GitHub account settings and push a new commit to this PR.

@DanSoQt
Copy link
Contributor

DanSoQt commented Dec 3, 2024

Sorry for the dupe comment spam. I'm trying to get this bot deployed and we don't have a test-github instance :)

@EgorWeders
Copy link
Author

If you wish for this PR to be considered, please update your email address privacy settings in your GitHub account settings and push a new commit to this PR.

@DanSoQt does the bot distinguish between merge commits and other commits?

@DanSoQt
Copy link
Contributor

DanSoQt commented Dec 11, 2024

Not as far as author is concerned, no. Merge commits get discarded in the process, but the author is taken from the last commit, no matter what it was. The bot isn't yet running in automatic mode, but I'll have it try your change again today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorWeders @DanSoQt