Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildSrc convention plugins #102

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Oct 25, 2022

Reduce the amount of config in build.gradle.kts by creating buildSrc convention plugins. This shouldn't have any functional impact.

Depends on #100

  • set up buildSrc
  • create convention plugins for Kotlin, Gradle Plugin, and publishing
  • starts using the JVM Test Suite plugin. No functional tests are added here - this is just laying groundwork.
  • defines a project-local Maven repository for testing publication (I find this much more convenient than publishing to Maven Local, as the repo is more easily accessed and deleted). Run ./gradlew publishAllPublicationsToProjectLocalRepository and look in ./build/maven-project-local to test it.

@aSemy aSemy marked this pull request as draft October 25, 2022 18:12
@aSemy
Copy link
Contributor Author

aSemy commented Oct 25, 2022

LGTM is failing because of Java versions - it looks like it's using jdk8?

[2022-10-25 18:23:53] [build-stdout] [2022-10-25 18:23:53] [autobuild] > There was a failure while executing work items
[2022-10-25 18:23:53] [build-stdout] [2022-10-25 18:23:53] [autobuild]    > A failure occurred while executing org.gradle.plugin.devel.tasks.internal.ValidateAction
[2022-10-25 18:23:53] [build-stdout] [2022-10-25 18:23:53] [autobuild]       > gradle/kotlin/dsl/plugins/_8d667f1efb3570b8d0df88ad0d3b48e4/OrgPluginGroup has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

The banner says it's shutting down in a few months, so perhaps it's just best to migrate to the replacements

image

@qoomon
Copy link
Owner

qoomon commented Oct 26, 2022

I've replaced LGTM with CodeQL 876fc5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants