Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dowload files support #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dowload files support #49

wants to merge 2 commits into from

Conversation

biegehydra
Copy link

@biegehydra biegehydra commented May 26, 2023

Additions

  • Two additional configurations
    • allowDownloadAll - Permits users to zip an entire folder (non recursive) and download it
    • allowDownload - Permits users to download individual files
  • 1 additional dependency
    • For zipping files I used JSZip

DownloadAll

@qoomon qoomon self-requested a review May 26, 2023 22:17
@qoomon qoomon self-assigned this May 26, 2023
@biegehydra
Copy link
Author

@qoomon Anything need fixed for this to be brought in?

@qoomon
Copy link
Owner

qoomon commented Aug 4, 2023

sorry for the late response, I'll try to review it this weekend

const urlObject = window.URL || window.webkitURL;
const objectUrl = urlObject.createObjectURL(content);

const link = document.createElement('a');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the download logic to a separate function

let objectUrl = urlObject.createObjectURL(data);

let link = document.createElement('a');
link.href = objectUrl;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the download logic to a separate function

@qoomon
Copy link
Owner

qoomon commented Aug 7, 2023

Hi, thanks for the PR.
Some opinion brainstorming:

  • I don't think we need the option allowDownload
  • We need to have a progress bar for file downloading status
  • Mabe Download Allshould download really all files including paginated files
  • Maybe we should add checkboxes to mark which files we want to download
  • We should add a dialogue to ensure someone really wants to download X files with a size of Y
  • What about an option to download all files including subdirectories?
  • What about a file count or size limit?

WDYT?

@biegehydra
Copy link
Author

biegehydra commented Aug 18, 2023

  • I don't think we need the option allowDownload
  • We need to have a progress bar for file downloading status
  • Mabe Download Allshould download really all files including paginated files
  • Maybe we should add checkboxes to mark which files we want to download
  • We should add a dialogue to ensure someone really wants to download X files with a size of Y
  • What about an option to download all files including subdirectories?
  • What about a file count or size limit?

WDYT?

I think they're all good ideas. I'm not that familiar with Vue or Buefy so adding all these features will be difficult for me. I'll take a wack at it when I get the chance though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants