add QuizBot #262
Open
add QuizBot #262
+229
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users can add and remove a bot to a multiplayer room, the bot answers questions
JeliHacker
force-pushed
the
Project/QuizBot
branch
from
c46252a
to
a37ee92
Compare
JeliHacker
force-pushed
the
Project/QuizBot
branch
from
a37ee92
to
5b3cd34
Compare
VillainsRule
suggested changes
May 16, 2024
| @@ -769,7 +778,7 @@ function upsertPlayerItem(player) { | |||
| playerItem.id = `list-group-${userId}`; | |||
| playerItem.innerHTML = ` | |||
| <div class="d-flex justify-content-between"> | |||
| <span id="username-${userId}">${escapeHTML(username)}</span> | |||
| <span id="username-${userId}">${player.userId == 'QuizBotId' ? '<i class="fa-solid fa-robot"></i> ' : ''}${escapeHTML(username)}</span> | |||
There was a problem hiding this comment.
Can't userIDs be spoofed by a user if directly connecting to the WebSocket?
| isOnline: true, // You might want to always consider the bot as online | ||
| }; | ||
|
|
||
| upsertPlayerItem(quizBotPlayer); |
There was a problem hiding this comment.
Why doesn't the server send this player instead of the client?
There was a problem hiding this comment.
I might've misunderstood how these are added, if so, my bad.
| @@ -185,6 +192,15 @@ class TossupRoom { | |||
| const type = message.type || ''; | |||
|
|
|||
| switch (type) { | |||
| case 'bot-difficulty': | |||
| this.settings.botDifficulty = message.value; | |||
There was a problem hiding this comment.
Please add invalidations for what this can be, from what I can tell a user could input a string as a value here.
| type: 'join', | ||
| isNew: true, | ||
| userId: 'QuizBotId', | ||
| username: '🤖QuizBot🤖', |
There was a problem hiding this comment.
This username should be blacklisted from account creation or names in public games, as that could lead to impersonation/abuse.
|
+ how hard would it be to add to singleplayer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bot solution for issue #10. It's not true artificial intelligence, but this lets users play against the computer.
Like @geoffrey-wu said,
The bot difficulty is in a range from 0-100, just like reading speed. You can think of the difficulty as the percentage of the question that is unread when the bot buzzes in. So if difficulty is set to 90, the bot will buzz in when 90% of the question is unread. At 100% the bot buzzes in instantly and at 0 it doesn't buzz in at all.
I made this a feature for multiplayer rooms instead of single player. I just find myself using a multiplayer room by myself instead of single player mode. Could be personal preference though