feat: add transaction export as JSON #50
Conversation
morremeyer
force-pushed
the
feat/transactions
branch
from
d935d67
to
fb25982
Compare
morremeyer
changed the title
morremeyer
force-pushed
the
feat/transactions
branch
from
fb25982
to
478fa8f
Compare
pytr/main.py
Outdated
| description=info, | ||
| ) | ||
| transactions.add_argument( | ||
| 'output', help='Output path of CSV file', metavar='OUTPUT', type=Path) |
There was a problem hiding this comment.
For some commands output is a file, sometimes a folder. That may be confusing, no?
There was a problem hiding this comment.
I think I can't quite follow this comment.
I took a look at export_transactions when writing this, where the file is specified, too.
I prefer that over only specifying a folder, because it is easy to use in scripts.
|
Thanks for your feedback, I'll address it in the upcoming days! |
morremeyer
force-pushed
the
feat/transactions
branch
from
478fa8f
to
6dfcbda
Compare
There was a problem hiding this comment.
@Katzmann1983 I added all your suggestions, thanks for the detailed review!
Sorry for the force push here, I only realized once I had already pushed.
My only question is in regards to the output parameter, I don't think I quite got your comment there.
pytr/main.py
Outdated
| description=info, | ||
| ) | ||
| transactions.add_argument( | ||
| 'output', help='Output path of CSV file', metavar='OUTPUT', type=Path) |
There was a problem hiding this comment.
I think I can't quite follow this comment.
I took a look at export_transactions when writing this, where the file is specified, too.
I prefer that over only specifying a folder, because it is easy to use in scripts.
This adds a
transactionscommand that is similar to theexport_transactionscommand.However,
transactionsuses thetimelineTransactions, which contain all transactions and exports the JSON as seen on the websocket to a target file.