Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip "ghcr.io/" from prefix for docker images in release channel #5189

Merged
merged 13 commits into from
May 28, 2024
Merged

Strip "ghcr.io/" from prefix for docker images in release channel #5189

merged 13 commits into from
May 28, 2024

Conversation

juliagmt-google
Copy link
Contributor

Strip "ghcr.io/" from prefix for docker images in release channel

@juliagmt-google
Update generate_docker_release_matrix.py
4260066 
Strip "ghcr.io/" from prefix for docker images in release channel
@vercel Vercel
Copy link

vercel bot commented May 8, 2024

@juliagmt-google is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2024
atalman
atalman reviewed May 8, 2024
View reviewed changes
tools/scripts/generate_docker_release_matrix.py Outdated
@@ -29,7 +29,7 @@ def generate_docker_matrix(channel: str) -> Dict[str, List[Dict[str, str]]]:
prefix = "ghcr.io/pytorch/pytorch"
docker_image_version = ""
if channel == "release":
docker_image_version = f"{prefix}:{generate_binary_build_matrix.CURRENT_STABLE_VERSION}"
docker_image_version = f"{prefix.replace("ghcr.io/", "")}:{generate_binary_build_matrix.CURRENT_STABLE_VERSION}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we probably want to pass another flag. Something like generate_dockerhub_images since we still want to validate ghcr.io release images before uploading to dockerhub.

@juliagmt-google
Copy link
Contributor Author

generate_docker_release_matrix.py --channel release --generate_dockerhub_images
{"include": [{"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "runtime", "docker": "pytorch/pytorch:2.3.0-cuda11.8-cudnn8-runtime", "platform": "linux/amd64", "validation_runner": "linux.g5.4xlarge.nvidia.gpu"}, {"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "devel", "docker": "pytorch/pytorch:2.3.0-cuda11.8-cudnn8-devel", "platform": "linux/amd64", "validation_runner": "linux.g5.4xlarge.nvidia.gpu"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "runtime", "docker": "pytorch/pytorch:2.3.0-cuda12.1-cudnn8-runtime", "platform": "linux/amd64", "validation_runner": "linux.g5.4xlarge.nvidia.gpu"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "devel", "docker": "pytorch/pytorch:2.3.0-cuda12.1-cudnn8-devel", "platform": "linux/amd64", "validation_runner": "linux.g5.4xlarge.nvidia.gpu"}, {"cuda": "cpu", "cuda_full_version": "", "cudnn_version": "", "image_type": "runtime", "docker": "pytorch/pytorch:2.3.0-runtime", "platform": "linux/arm64", "validation_runner": "linux.arm64.2xlarge"}]}

@atalman
Copy link
Contributor

atalman commented May 10, 2024

Looks better, we also need to add a new input here: https://github.com/pytorch/test-infra/blob/main/.github/workflows/generate_docker_release_matrix.yml
And pass this variable to a the script.

@atalman atalman merged commit bab2ee3 into pytorch:main May 28, 2024
5 of 6 checks passed
@juliagmt-google juliagmt-google mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juliagmt-google @atalman @facebook-github-bot