Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lintrunner from test infra #4947

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove lintrunner from test infra #4947

wants to merge 2 commits into from

Conversation

PaliC
Copy link
Contributor

@PaliC PaliC commented Feb 12, 2024

remove lintrunner from test infra


Stack created with Sapling. Best reviewed with ReviewStack.

PaliC added 2 commits January 16, 2024 14:26
Adds a rule/some text to help the logviewer understand mergability errors
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 10:42pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2024
@clee2000
Copy link
Contributor

where's it getting moved to?

unrelated but does sapling show the dependencies' changes? I'm seeing some changes related to the logviewer mergability failures PR

@PaliC
Copy link
Contributor Author

PaliC commented Feb 14, 2024

@clee2000 oops thanks! (will just remake the PR)

Generally, suo took it back to suo/lintrunner. Before, the next release the plan is to move it to pytorch-labs/lintrunner. Since lintrunner is inside the test-infra repository it wasn't obvious where folks were supposed to post issues regarding lintrunner so they either ended up in suo/lintrunner or they pinged suo directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants