Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Regression test CI GPU and CPU #3147

Merged
merged 13 commits into from
May 21, 2024
Merged

Fixing Regression test CI GPU and CPU #3147

merged 13 commits into from
May 21, 2024

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented May 21, 2024

Description

Fixing binary regression test workflow for both CPU and GPU

Tests

GPU: https://github.com/pytorch/serve/actions/runs/9166257368
CPU: https://github.com/pytorch/serve/actions/runs/9166720968

Notes

Pinning transformers to version 4.40.2 due to newer version causing issues with continuous batching
Examples:
https://github.com/pytorch/serve/actions/runs/9165678469/job/25199613724
https://github.com/pytorch/serve/actions/runs/9145615468/job/25144773494

@udaij12 udaij12 marked this pull request as ready for review May 21, 2024 01:14
@udaij12 udaij12 requested a review from agunapal May 21, 2024 01:14
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@udaij12 I would say, lets not pin the transformers version. They make frequent releases and we will get too many dependabot alerts. Instead, can you please skip the continuous batching test and file a GH issue to fix it.
cc @mreso

@udaij12
Copy link
Collaborator Author

udaij12 commented May 21, 2024

GH issue related to transformer version: #3148

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal enabled auto-merge May 21, 2024 17:30
@udaij12 udaij12 disabled auto-merge May 21, 2024 18:27
@udaij12 udaij12 added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit cb3fade May 21, 2024
12 checks passed
@udaij12 udaij12 deleted the ci_fixes branch May 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants