Remove branch from ReferenceAnalysis mod implementation #126170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126170
Note: Links to docs will display an error until the docs builds have been completed. ❌ 22 New FailuresAs of commit 8b7d907 with merge base 96a5698 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: cpu
ezyang
added a commit
that referenced
this pull request
May 14, 2024
This is still slightly wrong for floats, but it covers the most common case. A proper fix involves refactoring all of the modulus machinery to distinguish between Python modulus and C modulus, and a way of preferentially converting things into C modulus as much as possible. Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: da4baf40ad087b7191f110c02e520c0c64c71950 Pull Request resolved: #126170
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
miladm and
SherlockNoMad
ezyang
requested review from
lezcano
and removed request for
miladm,
albanD,
SherlockNoMad,
bdhirsh and
antoniojkim
lezcano
approved these changes
May 14, 2024
ezyang
added
release notes: composability
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
MEHHHH maybe I will just fix this properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is still slightly wrong for floats, but it covers the most common
case. A proper fix involves refactoring all of the modulus machinery to
distinguish between Python modulus and C modulus, and a way of
preferentially converting things into C modulus as much as possible.
Bandaids over #125376
Signed-off-by: Edward Z. Yang [email protected]
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang