[dynamo][cpp-guards] Improve recompilation reason logic for NO_TENSOR_ALIASING guard #125439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ALIASING guard [ghstack-poisoned]
This was referenced May 2, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125439
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit be8b9bd with merge base 3b5f6b1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 2, 2024
anijain2305
added a commit
that referenced
this pull request
May 2, 2024
…_ALIASING guard ghstack-source-id: 9525e113c7aa8469e491ec268579d5e481220569 Pull Request resolved: #125439
…r NO_TENSOR_ALIASING guard" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 2, 2024
…_ALIASING guard ghstack-source-id: 63b5c844aa7529fd7fec0592b87c51c6ab0fdfa6 Pull Request resolved: #125439
williamwen42
approved these changes
May 2, 2024
torch/csrc/dynamo/guards.cpp
Outdated
| @@ -1305,9 +1301,6 @@ class NO_TENSOR_ALIASING : public RelationalGuard { | |||
| if (!result) { | |||
| std::stringstream fail_reason; | |||
There was a problem hiding this comment.
Could just use a regular std::string here?
torch/_dynamo/guards.py
Outdated
| @@ -2419,7 +2440,16 @@ def get_guard_fail_reason( | |||
| # walk through this list and find the guard that failed. This is | |||
| # very important for symbolic shape guards which are currently | |||
| # installed as a lambda guard and can encompass a long list of code_parts. | |||
| if len(verbose_code_parts) == 1: | |||
|
|
|||
| if ( | |||
…r NO_TENSOR_ALIASING guard" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 2, 2024
…_ALIASING guard ghstack-source-id: 0b135e6530e40c316777bb502ba0d835b7cbaa34 Pull Request resolved: #125439
…r NO_TENSOR_ALIASING guard" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 3, 2024
…odule (#125421) Pull Request resolved: #125421 Approved by: https://github.com/mlazos ghstack dependencies: #125439
pytorchmergebot
pushed a commit
that referenced
this pull request
May 4, 2024
Improves the guard overhead of MobileBert model with nn module guards from 92000 units to 20000 units. Pull Request resolved: #124522 Approved by: https://github.com/jansel ghstack dependencies: #125439, #125421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang