Add logging for NO_SUCH_SUBOBJ #125410
Open
Add logging for NO_SUCH_SUBOBJ #125410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
reviewed
May 2, 2024
| @@ -828,6 +832,7 @@ def var_getattr(self, tx, name): | |||
| subobj = self._getattr_static(name) | |||
| except AttributeError: | |||
| subobj = NO_SUCH_SUBOBJ | |||
| log.warning(f"NO_SUCH_SUBOBJ: {self.value} {name}") | |||
There was a problem hiding this comment.
Why not just log the exception with logging.exception?
Skylion007
approved these changes
May 2, 2024
xmfan
reviewed
May 2, 2024
| @@ -828,6 +832,7 @@ def var_getattr(self, tx, name): | |||
| subobj = self._getattr_static(name) | |||
| except AttributeError: | |||
| subobj = NO_SUCH_SUBOBJ | |||
| log.warning(f"NO_SUCH_SUBOBJ: {self.value} {name}") | |||
There was a problem hiding this comment.
More user-facing? e.g. "Attribute {name} does not exist on {self.value}, falling back to NO_SUCH_SUBOBJ"
There was a problem hiding this comment.
Can we also add the log of self.value.__class__?
|
Can we also add the fallback warning to pytorch/torch/_dynamo/variables/user_defined.py Lines 801 to 803 in 799f146 |
fegin
approved these changes
May 6, 2024
jansel
requested changes
May 6, 2024
| @@ -828,6 +832,7 @@ def var_getattr(self, tx, name): | |||
| subobj = self._getattr_static(name) | |||
| except AttributeError: | |||
| subobj = NO_SUCH_SUBOBJ | |||
| log.warning(f"NO_SUCH_SUBOBJ: {self.value} {name}") | |||
There was a problem hiding this comment.
This doesn't seem like something we should warn on. This is valid user code:
try:
x = foo.x
except AttributeError:
x = None
It would be super annoying to emit a warning for this.
There was a problem hiding this comment.
Let's pass exc_info=True too to get the full exception stack trace + exception object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult to tell where NO_SUCH_SUBOBJ occurs from current log, which happens often during compiled autograd enablement. This PR should help surface more information.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang