Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce torch.utils._sympy.symbol #125395

Closed
wants to merge 6 commits into from
Closed

Introduce torch.utils._sympy.symbol #125395

wants to merge 6 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented May 2, 2024 •
edited

Stack from ghstack (oldest at bottom):

This provides utilities for creating and querying properties on
sympy.Symbol. I want to use this refactor to get a better handle on how
the 's' prefix is being used in Inductor. To start, I only do
symbolic_shapes code because that's what I'm familiar with.

Signed-off-by: Edward Z. Yang [email protected]

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

@ezyang
Update
2c650ad 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 2, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125395

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1d88af2 with merge base 79af814 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-td-distributed ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor release notes: fx release notes category labels May 2, 2024
ezyang added a commit that referenced this pull request May 2, 2024
@ezyang
Introduce torch.utils._sympy.symbol
09f3fb6 
This provides utilities for creating and querying properties on
sympy.Symbol.  I want to use this refactor to get a better handle on how
the 's' prefix is being used in Inductor.  To start, I only do
symbolic_shapes code because that's what I'm familiar with.

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: ea837fb9b1be9a09a317d7eb27bfc7bf276e81e8
Pull Request resolved: #125395
@ezyang ezyang added the topic: not user facing topic category label May 2, 2024
This was referenced May 2, 2024
Closed
Open
@ezyang
Update
b6a9953 
[ghstack-poisoned]
@albanD albanD removed their request for review May 2, 2024 20:22
OnlyFor pushed a commit to OnlyFor/pytorch that referenced this pull request May 3, 2024
@ezyang
Introduce torch.utils._sympy.symbol
a05a2f1 
This provides utilities for creating and querying properties on
sympy.Symbol.  I want to use this refactor to get a better handle on how
the 's' prefix is being used in Inductor.  To start, I only do
symbolic_shapes code because that's what I'm familiar with.

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: ea837fb9b1be9a09a317d7eb27bfc7bf276e81e8
Pull Request resolved: pytorch#125395
@ezyang
Update
f7e9f56 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 3, 2024
@ezyang
Introduce torch.utils._sympy.symbol
2ca1502 
This provides utilities for creating and querying properties on
sympy.Symbol.  I want to use this refactor to get a better handle on how
the 's' prefix is being used in Inductor.  To start, I only do
symbolic_shapes code because that's what I'm familiar with.

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: fdc5bf1c8ecb70d88c913f169af8d0c90faebddc
Pull Request resolved: #125395
@ezyang
Update
4e89502 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 3, 2024
@ezyang
Introduce torch.utils._sympy.symbol
59acac5 
This provides utilities for creating and querying properties on
sympy.Symbol.  I want to use this refactor to get a better handle on how
the 's' prefix is being used in Inductor.  To start, I only do
symbolic_shapes code because that's what I'm familiar with.

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: c17b7f4e4dd29167acd6645d2490168dc6ebcf16
Pull Request resolved: #125395
ezyang added 2 commits May 3, 2024 06:44
@ezyang
Update
bd14552 
[ghstack-poisoned]
@ezyang
Update
1d88af2 
[ghstack-poisoned]
This was referenced May 2, 2024
Closed
Closed
@ezyang
Copy link
Contributor Author

ezyang commented May 3, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 3, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced May 3, 2024
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request May 4, 2024
@ezyang @pytorchmergebot
Extend torch.utils._sympy.symbol for more Inductor symbols (#125419)
6f70d22 
I'm still missing a few, cdzq at least

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #125419
Approved by: https://github.com/lezcano
ghstack dependencies: #125395
OnlyFor pushed a commit to OnlyFor/pytorch that referenced this pull request May 4, 2024
@ezyang
Introduce torch.utils._sympy.symbol
43662e6 
This provides utilities for creating and querying properties on
sympy.Symbol.  I want to use this refactor to get a better handle on how
the 's' prefix is being used in Inductor.  To start, I only do
symbolic_shapes code because that's what I'm familiar with.

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: 84d52f217a07e983db1adcf4acba4dd0c28d7c9d
Pull Request resolved: pytorch#125395
pytorchmergebot pushed a commit that referenced this pull request May 5, 2024
@ezyang @pytorchmergebot
Split wrap_symint out of wrap_unspecialized_primitive (#125483)
617e473 
While there are some similarities, they are also quite different (one
handles Numpy numbers while the other handles ints.  I am also going to
add a wrap_symfloat soon which will do even more different behavior.
So split these out for clarity.

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #125483
Approved by: https://github.com/lezcano
ghstack dependencies: #125395, #125419
pytorchmergebot pushed a commit that referenced this pull request May 5, 2024
@ezyang @pytorchmergebot
Don't use wrap_fx_proxy_cls for wrap_symint (#125494)
12da7ee 
We use very little of the code in wrap_fx_proxy_cls, so dupe it out.

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #125494
Approved by: https://github.com/lezcano
ghstack dependencies: #125395, #125419, #125483
pytorchmergebot pushed a commit that referenced this pull request May 5, 2024
@ezyang @pytorchmergebot
Rename is_unspecialized to pass_arg_as_tensor, add comment (#125496)
650a248 
Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #125496
Approved by: https://github.com/lezcano
ghstack dependencies: #125395, #125419, #125483, #125494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@jansel jansel Awaiting requested review from jansel

@lezcano lezcano Awaiting requested review from lezcano

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

Assignees
No one assigned
Labels
ci-td-distributed ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor release notes: fx release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ezyang @pytorchmergebot @Skylion007