Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds some overloads for the add_argument method #13053

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adds some overloads for the add_argument method #13053

wants to merge 8 commits into from
+100 −1

Conversation

Diogo-Rossi
Copy link
Contributor

This is to foresee some exceptions like:

TypeError: _StoreAction.__init__() got an unexpected keyword argument 'version'
TypeError: _StoreConstAction.__init__() got an unexpected keyword argument 'nargs'
TypeError: _StoreConstAction.__init__() got an unexpected keyword argument 'type'
TypeError: _StoreTrueAction.__init__() got an unexpected keyword argument 'type'
TypeError: _StoreTrueAction.__init__() got an unexpected keyword argument 'choices'
TypeError: _CountAction.__init__() got an unexpected keyword argument 'type'
TypeError: _CountAction.__init__() got an unexpected keyword argument 'choices'

Diogo-Rossi and others added 8 commits November 20, 2024 16:42
@Diogo-Rossi
overload for "store" action
4d10844 
ref: https://github.com/python/cpython/blob/fd9c2a372704ae07654ca9841261834b0738757a/Lib/argparse.py#L910-L923
@Diogo-Rossi
overload for "store_const" action
9fc84bf 
ref: https://github.com/python/cpython/blob/fd9c2a372704ae07654ca9841261834b0738757a/Lib/argparse.py#L947-L957
@Diogo-Rossi
overload for "store_true" and "store_false" actions
bd8f29f 
ref: https://github.com/python/cpython/blob/fd9c2a372704ae07654ca9841261834b0738757a/Lib/argparse.py#L972C24-L1007
@Diogo-Rossi
overload for "append" action
2e9c9e4 
ref: https://github.com/python/cpython/blob/40b9b506fb88c5cb6d36617015d74b2cf21da43d/Lib/argparse.py#L1010-L1023
@Diogo-Rossi
overload for "append_const" action
9078efb
@Diogo-Rossi
overload for "count" action
752f2ae
@Diogo-Rossi
overload for "help" and "version" actions
5d502a5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
57359b1
@github-actions GitHub Actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

nox (https://github.com/wntrblm/nox)
+ nox/_option_set.py:288: error: Unused "type: ignore" comment  [unused-ignore]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Diogo-Rossi