Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 765: specify when the SyntaxWarning will be emitted, and explain why #4132

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 21, 2024

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4132.org.readthedocs.build/

peps/pep-0765.rst Outdated Show resolved Hide resolved
@konstin
Copy link
Contributor

konstin commented Nov 21, 2024

This does not need to be solve here, but it's relevant to this change: In uv, we found that the current behavior of emitting syntax warnings is confusing to users, with the defaults from pip they don't see the syntax warnings. astral-sh/uv#1928 (comment)

@hauntsaninja
Copy link
Contributor

hauntsaninja commented Nov 21, 2024

Yes, uv's current default behaviour is to skip precompilation at installation time. If a uv user uses --compile-bytecode they will not see a warning (most users should use that flag! especially if uv implements astral-sh/uv#2637 to match pip's performance)

peps/pep-0765.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iritkatriel iritkatriel merged commit aa1603b into python:main Nov 21, 2024
5 checks passed
@iritkatriel iritkatriel deleted the syntax_warning branch November 21, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants