Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 683: Mark Final #3824

Merged
merged 4 commits into from
Jun 12, 2024
Merged

PEP 683: Mark Final #3824

merged 4 commits into from
Jun 12, 2024

Conversation

ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Jun 6, 2024 •
edited by ericsnowcurrently
Loading

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3817

📚 Documentation preview 📚: https://pep-previews--3824.org.readthedocs.build/

@ncoghlan ncoghlan marked this pull request as draft June 6, 2024 07:58
@ncoghlan ncoghlan mentioned this pull request Jun 6, 2024
Open
4 tasks
hugovk
hugovk reviewed Jun 6, 2024
View reviewed changes
peps/pep-0683.rst Outdated Show resolved Hide resolved
@ericsnowcurrently
Copy link
Member

I don't see any issues with the implementation and there we're any major changes after acceptance.

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review June 12, 2024 18:00
@ericsnowcurrently ericsnowcurrently merged commit 764f563 into python:main Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncoghlan @ericsnowcurrently @hugovk