Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 667: Mark as Accepted #3784

Merged
merged 3 commits into from
May 17, 2024
Merged

PEP 667: Mark as Accepted #3784

merged 3 commits into from
May 17, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 15, 2024

  • SC/PEP Delegate has formally accepted/rejected the PEP and posted to the Discussions-To thread
  • Pull request title in appropriate format (PEP 123: Mark as Accepted)
  • Status changed to Accepted/Rejected
  • Resolution link points directly to SC/PEP Delegate official acceptance/rejected post
  • Acceptance/rejection notice added, if the SC/PEP delegate had major conditions or comments
  • Discussions-To, Post-History and Python-Version up to date

馃摎 Documentation preview 馃摎: https://pep-previews--3784.org.readthedocs.build/pep-0667/

@hugovk
Copy link
Member

hugovk commented May 15, 2024

  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

This is needed.

For PEP 667, https://docs.python.org/3.13/whatsnew/3.13.html#summary-release-highlights links to https://docs.python.org/3.13/reference/datamodel.html#frame.f_locals.

Perhaps this is enough?

@Eclips4
Copy link
Member Author

Eclips4 commented May 15, 2024

  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

This is needed.

For PEP 667, https://docs.python.org/3.13/whatsnew/3.13.html#summary-release-highlights links to https://docs.python.org/3.13/reference/datamodel.html#frame.f_locals.

Perhaps this is enough?

I would also like to point out the "locals" function, as PRs with doc updates change its description: https://github.com/python/cpython/pull/118265/files
What do you think about that?

@hugovk
Copy link
Member

hugovk commented May 16, 2024

Following the 馃敀 Discord discussion, let's only mark as Accepted for now.

Please could you update the PR? We don't need the canonical docs banner yet, and there should be some more docs added during the sprint.

@Eclips4 Eclips4 changed the title PEP 667: Mark as Accepted & Final PEP 667: Mark as Accepted May 16, 2024
@Eclips4
Copy link
Member Author

Eclips4 commented May 16, 2024

Following the 馃敀 Discord discussion, let's only mark as Accepted for now.

Please could you update the PR? We don't need the canonical docs banner yet, and there should be some more docs added during the sprint.

Done!

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 134897b into python:main May 17, 2024
6 checks passed
@Eclips4 Eclips4 deleted the pep_667 branch May 24, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants