Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not forget that a TypedDict was wrapped in Unpack after a name-defined error occurred. #17226

Conversation

tyralla
Copy link
Contributor

@tyralla tyralla commented May 8, 2024

Do not set the unpacked_kwargs attribute of CallableType to False when visiting a callable of which the Unpack wrapper of a TypedDict has already been removed.

Fixes #17225

… when visiting a callable of which the `Unpack` wrapper of a `TypedDict` has already been removed.
Copy link
Contributor

github-actions bot commented May 8, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ilevkivskyi ilevkivskyi merged commit 6bdd854 into python:master Jun 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name-defined error lets Mypy forget TypedDict was wrapped in Unpack
2 participants