gh-114940: Add a Per-Interpreter Lock For the List of Thread States #127115
+114
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2024
|
There's a bit of code in |
|
Ideally we could build on top of gh-127121 for the recursive lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new lock may be used instead of the global "HEAD" lock. That global lock guards the list of interpreters, but unfortunately in some situations (like for
interp->threads.head) it has been used as a generic "lock everything". This change helps us move away from that situation.Note that there are 3 places in pystate.c where we have left
HEAD_LOCK()/HEAD_UNLOCK()in place:interpreter_clear()new_threadstate()tstate_delete_common()Otherwise we end up breaking a constraint on free-threaded builds.
Co-authored-by: RUANG (James Roy) [email protected]